brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loginDialog: Sync :expanded better with user list visibility

Browse Source 
Now that we use a different text style for the username depending on
whether the user list is expanded or not, changing the :expanded style
before the actual transition looks disruptive. Adding the style right
before fading in other items and removing it right after fading them
out gives a better result.

https://bugzilla.gnome.org/show_bug.cgi?id=685201
This commit is contained in:
Florian Müllner 2012-10-05 17:01:31 +02:00
parent dc15df1aa7
commit e8f96a6e16
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/gdm/loginDialog.js
View File

@ -275,13 +275,16 @@ const UserList = new Lang.Class({
}); });
} }
this._box.remove_style_pseudo_class('expanded');
let batch = new Batch.ConsecutiveBatch(this, let batch = new Batch.ConsecutiveBatch(this,
[function() { [function() {
return GdmUtil.fadeOutActor(this.actor.vscroll); return GdmUtil.fadeOutActor(this.actor.vscroll);
}, },
new Batch.ConcurrentBatch(this, tasks) new Batch.ConcurrentBatch(this, tasks),
function() {
this._box.remove_style_pseudo_class('expanded');
}
]); ]);
return batch.run(); return batch.run();
@ -331,7 +334,6 @@ const UserList = new Lang.Class({
}); });
} }
this._box.add_style_pseudo_class('expanded');
let batch = new Batch.ConsecutiveBatch(this, let batch = new Batch.ConsecutiveBatch(this,
[function() { [function() {
this.takeOverWhitespace(); this.takeOverWhitespace();
@ -342,6 +344,10 @@ const UserList = new Lang.Class({
return _smoothlyResizeActor(this._box, -1, fullHeight); return _smoothlyResizeActor(this._box, -1, fullHeight);
}, },
function() {
this._box.add_style_pseudo_class('expanded');
},
new Batch.ConcurrentBatch(this, tasks), new Batch.ConcurrentBatch(this, tasks),
function() { function() {