From e8f96a6e16266b3b57bf582e4049e9de44e48ea3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Fri, 5 Oct 2012 17:01:31 +0200 Subject: [PATCH] loginDialog: Sync :expanded better with user list visibility Now that we use a different text style for the username depending on whether the user list is expanded or not, changing the :expanded style before the actual transition looks disruptive. Adding the style right before fading in other items and removing it right after fading them out gives a better result. https://bugzilla.gnome.org/show_bug.cgi?id=685201 --- js/gdm/loginDialog.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js index d7fd1dc36..17a4ad6ec 100644 --- a/js/gdm/loginDialog.js +++ b/js/gdm/loginDialog.js @@ -275,13 +275,16 @@ const UserList = new Lang.Class({ }); } - this._box.remove_style_pseudo_class('expanded'); let batch = new Batch.ConsecutiveBatch(this, [function() { return GdmUtil.fadeOutActor(this.actor.vscroll); }, - new Batch.ConcurrentBatch(this, tasks) + new Batch.ConcurrentBatch(this, tasks), + + function() { + this._box.remove_style_pseudo_class('expanded'); + } ]); return batch.run(); @@ -331,7 +334,6 @@ const UserList = new Lang.Class({ }); } - this._box.add_style_pseudo_class('expanded'); let batch = new Batch.ConsecutiveBatch(this, [function() { this.takeOverWhitespace(); @@ -342,6 +344,10 @@ const UserList = new Lang.Class({ return _smoothlyResizeActor(this._box, -1, fullHeight); }, + function() { + this._box.add_style_pseudo_class('expanded'); + }, + new Batch.ConcurrentBatch(this, tasks), function() {