brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

authPrompt: Consume cancel key event

Browse Source 
The auth prompt currently propagates all key presses, even the
Escape press that is used to cancel it.

On the lock screen that means that the same event that cancels
the prompt (and switches back to the clock) is *also* propagated
to the handler that activates the prompt on key press.

That handler doesn't do anything when the prompt is already visible,
which is the case when the transition to the clock is animated.

However when animations are disabled, canceling the prompt will
result in a new prompt getting created immediately, and the login
screen is stuck on the prompt.

Fix this by not propagating key events that are used to cancel
the prompt.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3317>
This commit is contained in:
Florian Müllner 2024-05-15 01:55:40 +02:00 committed by Marge Bot
parent dac4f2cb86
commit e7dc0de75e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/gdm/authPrompt.js
View File

@ -134,8 +134,10 @@ export const AuthPrompt = GObject.registerClass({
}
on_key_press_event(event) {
if (event.get_key_symbol() === Clutter.KEY_Escape)
if (event.get_key_symbol() === Clutter.KEY_Escape) {
this.cancel();
return Clutter.EVENT_STOP;
}
return Clutter.EVENT_PROPAGATE;
}