brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shellEntry: Don't show "Show Password" menu if entry icon is disabled

Browse Source 
Right now the Show Password menu is shown unconditionally for password
entries, ignoring the org.gnome.desktop.lockdown disable-show-password
key.

StShellEntry now honors that key for its peek icon, and there's little
reason for the peek icon and the menu to ever be out of sync.

This commit forces the menu and the icon to always be in sync, and
so makes the menu lock down work automatically, too.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/687>
This commit is contained in:
Ray Strode 2021-07-21 14:01:48 -04:00 committed by Marge Bot
parent 8721c5db37
commit a4123887c1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/shellEntry.js
View File

@ -39,6 +39,10 @@ var EntryMenu = class extends PopupMenu.PopupMenu {
item.connect('activate', this._onPasswordActivated.bind(this)); item.connect('activate', this._onPasswordActivated.bind(this));
this.addMenuItem(item); this.addMenuItem(item);
this._passwordItem = item; this._passwordItem = item;
this._entry.bind_property('show-peek-icon',
this._passwordItem, 'visible',
GObject.BindingFlags.SYNC_CREATE);
} }
open(animate) { open(animate) {