From a4123887c1e129c28eb962d51c2ad05ff9e2ccfb Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Wed, 21 Jul 2021 14:01:48 -0400 Subject: [PATCH] shellEntry: Don't show "Show Password" menu if entry icon is disabled Right now the Show Password menu is shown unconditionally for password entries, ignoring the org.gnome.desktop.lockdown disable-show-password key. StShellEntry now honors that key for its peek icon, and there's little reason for the peek icon and the menu to ever be out of sync. This commit forces the menu and the icon to always be in sync, and so makes the menu lock down work automatically, too. Part-of: --- js/ui/shellEntry.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/js/ui/shellEntry.js b/js/ui/shellEntry.js index 38f5a836d..a2010b39e 100644 --- a/js/ui/shellEntry.js +++ b/js/ui/shellEntry.js @@ -39,6 +39,10 @@ var EntryMenu = class extends PopupMenu.PopupMenu { item.connect('activate', this._onPasswordActivated.bind(this)); this.addMenuItem(item); this._passwordItem = item; + + this._entry.bind_property('show-peek-icon', + this._passwordItem, 'visible', + GObject.BindingFlags.SYNC_CREATE); } open(animate) {