brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

status/backlight: Fix a11y label of discrete level buttons

Browse Source 
Point the discrete level buttons to the corresponding labels,
so that they don't appear as plain "button" in screen readers.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3545>
This commit is contained in:
Florian Müllner
2024-11-13 00:51:22 +01:00
committed by Marge Bot
parent 64c9baf412
commit 83a8810003
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
js/ui/status/backlight.js
View File

@ -106,17 +106,23 @@ const DiscreteItem = GObject.registerClass({
return 100 * Math.min(keyIndex, this.nLevels - 1) / (this.nLevels - 1);
}
_addLevelButton(key, label, iconName) {
_addLevelButton(key, labelText, iconName) {
const box = new St.BoxLayout({
style_class: 'keyboard-brightness-level',
vertical: true,
x_expand: true,
});
const label = new St.Label({
text: labelText,
x_align: Clutter.ActorAlign.CENTER,
});
box.button = new St.Button({
styleClass: 'icon-button',
canFocus: true,
iconName,
labelActor: label,
});
box.add_child(box.button);
@ -124,10 +130,7 @@ const DiscreteItem = GObject.registerClass({
this.value = this._levelToValue(key);
});
box.add_child(new St.Label({
text: label,
x_align: Clutter.ActorAlign.CENTER,
}));
box.add_child(label);
this.add_child(box);
this._levelButtons.set(key, box);