brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set this._notificationRemoved to false in _hideNotificationComplete()

Browse Source 
We used to set this._notificationRemoved to false in _hideNotification().
However, the user focusing on the associated application can result in the
source being removed while the notification is hiding, in which case
this._notificationRemoved was set to true and never unset. This resulted in
the next notification only showing up briefly and hiding. Moving setting
this._notificationRemoved to false to _hideNotificationComplete() fixes this
behavior.

https://bugzilla.gnome.org/show_bug.cgi?id=611122
This commit is contained in:
Marina Zhurakhinskaya 2010-02-25 16:19:11 -05:00
parent a4481b38d2
commit 732ba8576d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/messageTray.js
View File

@ -696,7 +696,6 @@ MessageTray.prototype = {
}, },
_hideNotification: function() { _hideNotification: function() {
this._notificationRemoved = false;
this._notification.popIn(); this._notification.popIn();
this._tween(this._notificationBin, "_notificationState", State.HIDDEN, this._tween(this._notificationBin, "_notificationState", State.HIDDEN,
@ -710,6 +709,7 @@ MessageTray.prototype = {
}, },
_hideNotificationCompleted: function() { _hideNotificationCompleted: function() {
this._notificationRemoved = false;
this._notificationBin.hide(); this._notificationBin.hide();
this._notificationBin.child = null; this._notificationBin.child = null;
this._notification = null; this._notification = null;