From 732ba8576d643dc8bb3d90e3e2868cc317def01a Mon Sep 17 00:00:00 2001 From: Marina Zhurakhinskaya Date: Thu, 25 Feb 2010 16:19:11 -0500 Subject: [PATCH] Set this._notificationRemoved to false in _hideNotificationComplete() We used to set this._notificationRemoved to false in _hideNotification(). However, the user focusing on the associated application can result in the source being removed while the notification is hiding, in which case this._notificationRemoved was set to true and never unset. This resulted in the next notification only showing up briefly and hiding. Moving setting this._notificationRemoved to false to _hideNotificationComplete() fixes this behavior. https://bugzilla.gnome.org/show_bug.cgi?id=611122 --- js/ui/messageTray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index fe7a08166..63d0d5dbd 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -696,7 +696,6 @@ MessageTray.prototype = { }, _hideNotification: function() { - this._notificationRemoved = false; this._notification.popIn(); this._tween(this._notificationBin, "_notificationState", State.HIDDEN, @@ -710,6 +709,7 @@ MessageTray.prototype = { }, _hideNotificationCompleted: function() { + this._notificationRemoved = false; this._notificationBin.hide(); this._notificationBin.child = null; this._notification = null;