appDisplay: Don't fade icons when a folder dialog is open

The folder dialog itself now has a background, there's no
need to fade the icons anymore.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1301

js/ui/appDisplay.js

@@ -24,10 +24,6 @@ var MAX_COLUMNS = 6;
 var MIN_COLUMNS = 4;
 var MIN_ROWS = 4;
 
-var INACTIVE_GRID_OPACITY = 77;
-// This time needs to be less than IconGrid.EXTRA_SPACE_ANIMATION_TIME
-// to not clash with other animations
-var INACTIVE_GRID_OPACITY_ANIMATION_TIME = 240;
 var FOLDER_SUBICON_FRACTION = .4;
 
 var VIEWS_SWITCH_TIME = 400;
@@ -721,7 +717,6 @@ class AppDisplay extends BaseAppView {
                     this._currentDialogDestroyId = 0;
                 });
             }
-            this._updateIconOpacities(isOpen);
             this._displayingDialog = isOpen;
         });
     }
@@ -731,22 +726,6 @@ class AppDisplay extends BaseAppView {
         this.goToPage(itemPage);
     }
 
-    _updateIconOpacities(folderOpen) {
-        for (let icon of this._items.values()) {
-            let opacity;
-            if (folderOpen && !icon.checked)
-                opacity =  INACTIVE_GRID_OPACITY;
-            else
-                opacity = 255;
-
-            icon.ease({
-                opacity,
-                duration: INACTIVE_GRID_OPACITY_ANIMATION_TIME,
-                mode: Clutter.AnimationMode.EASE_OUT_QUAD,
-            });
-        }
-    }
-
     // Called before allocation to calculate dynamic spacing
     adaptToSize(width, height) {
         let box = new Clutter.ActorBox();