brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st-icon: check if gicon is null before unref.

Browse Source 
Commit a6b49fe7d6c9bcd8a2be47a0b0b44cf9a53a45aa
introduced a check for equality of priv->gicon vs gicon
and unref then return early if so. But if both are null,
we should not unref gicon. Only return.

https://bugzilla.gnome.org/show_bug.cgi?id=698863
This commit is contained in:
Alban Browaeys 2013-04-25 18:25:12 +02:00 committed by Ray Strode
parent cdbb1bb665
commit 61b1679719
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/st/st-icon.c
View File

@ -539,6 +539,7 @@ st_icon_set_icon_name (StIcon *icon,
if (g_icon_equal (priv->gicon, gicon)) /* do nothing */ if (g_icon_equal (priv->gicon, gicon)) /* do nothing */
{ {
if (gicon)
g_object_unref (gicon); g_object_unref (gicon);
return; return;
} }