From 61b1679719fb59206a1f055037cff586072f63f8 Mon Sep 17 00:00:00 2001 From: Alban Browaeys Date: Thu, 25 Apr 2013 18:25:12 +0200 Subject: [PATCH] st-icon: check if gicon is null before unref. Commit a6b49fe7d6c9bcd8a2be47a0b0b44cf9a53a45aa introduced a check for equality of priv->gicon vs gicon and unref then return early if so. But if both are null, we should not unref gicon. Only return. https://bugzilla.gnome.org/show_bug.cgi?id=698863 --- src/st/st-icon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/st/st-icon.c b/src/st/st-icon.c index 9d52727c8..fac474af9 100644 --- a/src/st/st-icon.c +++ b/src/st/st-icon.c @@ -539,7 +539,8 @@ st_icon_set_icon_name (StIcon *icon, if (g_icon_equal (priv->gicon, gicon)) /* do nothing */ { - g_object_unref (gicon); + if (gicon) + g_object_unref (gicon); return; }