brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

popupMenu: Make checkAccessibleState() private

Browse Source 
Updating the accessible state is an internal business of the
class, so making it private is more appropriate.

Besides, it was never called from outside the class since it
was added in 2012, so it's unlikely we'll ever have a use case
for it.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3576>
This commit is contained in:
Florian Müllner 2024-12-16 15:04:18 +01:00 committed by Marge Bot
parent 46efbfb2ab
commit 3421a3825a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
js/ui/popupMenu.js
View File

@ -547,7 +547,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({
this.bind_property('reactive', this._switch, 'reactive', GObject.BindingFlags.SYNC_CREATE);
this.accessible_role = Atk.Role.CHECK_MENU_ITEM;
this.checkAccessibleState();
this._checkAccessibleState();
this.label_actor = this.label;
this.add_child(this.label);
@ -578,7 +578,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({
this.reactive = true;
this.accessible_role = Atk.Role.CHECK_MENU_ITEM;
}
this.checkAccessibleState();
this._checkAccessibleState();
}
activate(event) {
@ -604,15 +604,15 @@ export const PopupSwitchMenuItem = GObject.registerClass({
setToggleState(state) {
this._switch.state = state;
this.checkAccessibleState();
this._checkAccessibleState();
}
_onToggled() {
this.emit('toggled', this._switch.state);
this.checkAccessibleState();
this._checkAccessibleState();
}
checkAccessibleState() {
_checkAccessibleState() {
switch (this.accessible_role) {
case Atk.Role.CHECK_MENU_ITEM:
if (this._switch.state)