From 3421a3825a2ff8a35f0a2a3e7823f564d3746478 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Mon, 16 Dec 2024 15:04:18 +0100 Subject: [PATCH] popupMenu: Make checkAccessibleState() private Updating the accessible state is an internal business of the class, so making it private is more appropriate. Besides, it was never called from outside the class since it was added in 2012, so it's unlikely we'll ever have a use case for it. Part-of: --- js/ui/popupMenu.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js index ddd6ce7ed..5f94fcabd 100644 --- a/js/ui/popupMenu.js +++ b/js/ui/popupMenu.js @@ -547,7 +547,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({ this.bind_property('reactive', this._switch, 'reactive', GObject.BindingFlags.SYNC_CREATE); this.accessible_role = Atk.Role.CHECK_MENU_ITEM; - this.checkAccessibleState(); + this._checkAccessibleState(); this.label_actor = this.label; this.add_child(this.label); @@ -578,7 +578,7 @@ export const PopupSwitchMenuItem = GObject.registerClass({ this.reactive = true; this.accessible_role = Atk.Role.CHECK_MENU_ITEM; } - this.checkAccessibleState(); + this._checkAccessibleState(); } activate(event) { @@ -604,15 +604,15 @@ export const PopupSwitchMenuItem = GObject.registerClass({ setToggleState(state) { this._switch.state = state; - this.checkAccessibleState(); + this._checkAccessibleState(); } _onToggled() { this.emit('toggled', this._switch.state); - this.checkAccessibleState(); + this._checkAccessibleState(); } - checkAccessibleState() { + _checkAccessibleState() { switch (this.accessible_role) { case Atk.Role.CHECK_MENU_ITEM: if (this._switch.state)