brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Remove deprecated code

Browse Source 
Originally the Source method for showing notifications was "notify",
which had to change when turning it into a GObject subclass to not
clash with g_object_notify().

That change happened during the 3.36 cycle, so extensions have had
two releases (a year) to adapt to the replacement. That seems long
enough, so remove the deprecated compat code.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3848

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1749>
This commit is contained in:
Florian Müllner 2021-03-09 20:48:47 +01:00 committed by Marge Bot
parent e854b26fa7
commit 16c7739170
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
js/ui/messageTray.js
View File

@ -703,7 +703,7 @@ var Source = GObject.registerClass({
}
countUpdated() {
super.notify('count');
this.notify('count');
}
_createPolicy() {
@ -775,21 +775,6 @@ var Source = GObject.registerClass({
this.emit('notification-show', notification);
}
notify(propName) {
if (propName instanceof Notification) {
try {
throw new Error('Source.notify() has been moved to Source.showNotification()' +
'this code will break in the future');
} catch (e) {
logError(e);
this.showNotification(propName);
return;
}
}
super.notify(propName);
}
destroy(reason) {
let notifications = this.notifications;
this.notifications = [];