brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[lightbox] Fix logic; get_children() returns children bottom-to-top

Browse Source
This commit is contained in:
Dan Winship 2009-09-22 17:48:44 -04:00
parent 3734479cbd
commit 0b6d09bbe2
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
js/ui/lightbox.js
View File

@ -74,20 +74,20 @@ Lightbox.prototype = {
let myIndex = children.indexOf(this.actor); let myIndex = children.indexOf(this.actor);
let newChildIndex = children.indexOf(newChild); let newChildIndex = children.indexOf(newChild);
if (newChildIndex < myIndex) { if (newChildIndex > myIndex) {
// The child was added above the shade (presumably it was // The child was added above the shade (presumably it was
// made the new top-most child). Move it below the shade, // made the new top-most child). Move it below the shade,
// and add it to this._children as the new topmost actor. // and add it to this._children as the new topmost actor.
newChild.lower(this.actor); newChild.lower(this.actor);
this._children.unshift(newChild);
} else if (newChildIndex == children.length - 1) {
// Bottom of stack
this._children.push(newChild); this._children.push(newChild);
} else if (newChildIndex == 0) {
// Bottom of stack
this._children.unshift(newChild);
} else { } else {
// Somewhere else; insert it into the correct spot // Somewhere else; insert it into the correct spot
let nextChild = this._children.indexOf(children[newChildIndex + 1]); let prevChild = this._children.indexOf(children[newChildIndex - 1]);
if (nextChild != -1) // paranoia if (prevChild != -1) // paranoia
this._children.splice(nextChild, 0, newChild); this._children.splice(prevChild + 1, 0, newChild);
} }
}, },
@ -119,7 +119,7 @@ Lightbox.prototype = {
// sibling of the to-be-lowered one. // sibling of the to-be-lowered one.
let below = this.actor; let below = this.actor;
for (let i = 0; i < this._children.length; i++) { for (let i = this._children.length - 1; i >= 0; i--) {
if (this._children[i] == window) if (this._children[i] == window)
this._children[i].raise_top(); this._children[i].raise_top();
else if (this._children[i] == this._highlighted) else if (this._children[i] == this._highlighted)