isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,802 Commits 1 Branch 0 Tags
5bbfaa8e68b5ee6f27d4fbfa3c4e789341724f9c
Commit Graph

3857 Commits

Author SHA1 Message Date
Rose
725d3fdc20 Prefer putchar over fputc where possible 
putchar is easier to understand than fputc and printf and does less work than those two do.
 2024-01-13 15:24:43 -07:00
Rose
7fc7d69532 Add restrict qualifiers to strlcpy_no_slash 
It's just strlcpy except it replaces '/' with '_'.
 2024-01-13 15:20:10 -07:00
Todd C. Miller
67e328d6f8 Only log "a password is required" for "sudo -n" if a command is specified. 
This means that it is not logged for "sudo -nv" and "sudo -nl".
We only log this message when sudo's -n flag is specified (and not
when the user presses ^C at the password prompt) so that there is
a record of failed non-interactive commands.
 2024-01-10 13:54:41 -07:00
Todd C. Miller
ff3dbe60b1 Update "!use_pty" example to only disable it for non-root users. 
Also add a commented out entry for "exec_background" which can also
be used to prevent sudo from consuming tty input.
Related to GitHub issue #338
 2024-01-08 14:16:29 -07:00
Todd C. Miller
e4057faca2 Properly handle sysconf(_SC_LOGIN_NAME_MAX) returning -1 on failure. 
The cast to size_t needs to be outside the MAX() macro or the -1
will get cast to unsigned.
 2023-12-28 09:00:49 -07:00
Todd C. Miller
ad4dc22d5a Automatically migrate lecture file path from name-based to uid-based. 
GitHub issue #342.
 2023-12-22 09:39:24 -07:00
Todd C. Miller
5fbf7a3625 Disable netgroup_query when netgroup_base is not set. 
The logic was inverted when support for netgroup_query was added.
This supercedes PR #341.
 2023-12-19 20:16:35 -07:00
Todd C. Miller
7019148160 Fix printing of warning when a Defaults setting is missing a value. 
This is a bug in parse_default_entry() introduced in sudo 1.8.19
when support for using the default syslog facility was added at the
wrong place in a switch().
 2023-12-16 08:08:44 -07:00
Todd C. Miller
f67a7e623e Sprinkle some more const in defaults.c. 2023-12-15 15:05:02 -07:00
Todd C. Miller
2df637b262 Fix evaluation of a tuple used in "true" boolean context. 
Previously, a tuple in boolean context was always treated as a
negated entry, which doesn't match the documentation.  We assume
that there are at least two tuple entries where the first maps to
boolean false and the second maps to boolean true.
 2023-12-15 14:57:59 -07:00
Todd C. Miller
fbc4c50d4d sudoers_lookup_pseudo: init match to UNSPEC for sudo_nss_can_continue(). 
Otherwise, processing will stop after the first sudoers nsswitch
service specification where [SUCCESS=return] is present.
 2023-12-15 10:45:22 -07:00
Todd C. Miller
de242c5738 Pass back Solaris privs as "runas_privs" and "runas_limitprivs". 
The "runas_" prefix got inadvertantly removed in the big sudoers_context
refactor.
 2023-12-11 13:31:56 -07:00
Todd C. Miller
d17e28ad61 setup_terminal: fix an editing error introduced in 1.9.15. 2023-12-07 07:27:06 -07:00
Todd C. Miller
0c2de39da3 command_matches_regex: retry with canonicalized path if possible 
If ctx->user.cmnd doesn't match, use ctx->user.cmnd_dir (if present)
to construct a canonicalized path and match on that.
 2023-12-06 10:27:57 -07:00
Todd C. Miller
44f0908e73 command_matches_fnmatch: retry with canonicalized path if possible 
If ctx->user.cmnd doesn't match, use ctx->user.cmnd_dir (if present)
to construct a canonicalized path and match on that.
 2023-12-04 18:35:08 -07:00
Todd C. Miller
8faf432499 Fall back to "localhost" if gethostname() fails. 
GitHub issue #332
 2023-12-04 09:21:56 -07:00
Todd C. Miller
8dd2967766 command_matches_glob: fix comparison of canonicalized parent directories 
Bug #1062
 2023-12-04 09:08:52 -07:00
Todd C. Miller
9c3eb2feca Add missing print_member_list_csv() return value check. 2023-12-01 15:14:59 -07:00
Todd C. Miller
79ed29c4a3 Check sudoers_debug_register() return value. 2023-12-01 15:00:08 -07:00
Todd C. Miller
77700a4b7a Add cmddenial_message to def_data.in 2023-11-28 15:19:24 -07:00
THE-Spellchecker
5eba4b48cf Typographical and Grammatical fixes 2023-11-28 15:00:04 -07:00
Guillaume Destuynder
a4cbfecdae Add support for a custom message when the command execution is denied. 2023-11-28 14:19:26 -07:00
Todd C. Miller
522f1b634f tsdump: quiet compiler warnings on some platforms. 
Quiet a -Wshadow warning from gcc.
Cast major() and minor() to unsigned int when printing.
 2023-11-26 09:27:46 -07:00
Todd C. Miller
288593875d tsdump: display both the terminal path and device number. 
If no terminal device can be found, print "major, minor" device
numbers instead.
 2023-11-26 09:07:25 -07:00
Todd C. Miller
66c9a636d1 Build tsdump by default so it does not suffer bit rot. 2023-11-26 08:45:43 -07:00
Todd C. Miller
5ff6f49653 tsdump: update to use a uid-based path by default 
This matches the changes in sudo 1.9.15 to the sudoers policy module.
 2023-11-26 08:21:05 -07:00
Todd C. Miller
ce74f50b44 Update for plugin version 1.22. 2023-11-25 18:51:28 -07:00
Todd C. Miller
a85494b5c4 Add ttydev to sudoers_user_context and use for timestamp file. 
GitHub issue #329
 2023-11-25 16:26:45 -07:00
Todd C. Miller
b9275b7eab Rename submit_time -> event_time in struct eventlog. 2023-11-23 09:08:04 -05:00
Todd C. Miller
0e53d5fddf We can use evlog.submit_time in the call to eventlog_alert(). 
This is set to the current wallclock time by sudoers_to_eventlog().
 2023-11-23 09:08:04 -05:00
Todd C. Miller
39ea3176c1 Replace submit_time in struct sudoers_context with start_time. 
We need to track the (monotonic) command start time to be able to
generate an accurate run time.  Instead of setting submit time when
the policy initializes (and using that time for logging purposes),
set evlog->submit_time to the current wallclock time when we need
to perform logging.  This is more consistent with how sudo logging
was performed in the past.  Fixes GitHub issues #327.
 2023-11-23 09:08:04 -05:00
Todd C. Miller
432b085558 log_server_open: always pass in awake time, not wallclock time. 
The timespec passed to log_server_open() should be from
sudo_gettime_awake() since it is used to build the command run time.
 2023-11-23 09:08:04 -05:00
Todd C. Miller
6965e1b0aa log_server_alert: use fmt_alert_message not fmt_reject_message 
Only affects intercepted commands.
 2023-11-23 09:08:04 -05:00
Todd C. Miller
13dec64f3d log_server_alert: struct timespec argument was not actually used 
The struct timespec argument is used to initialize the command
start time, which is not used for an alert message.
 2023-11-23 09:08:04 -05:00
Todd C. Miller
47a43c5404 cvtsudoers_csv.c: remove most sudo_fatal() calls. 
Errors are now propagated up the call stack.
 2023-11-11 10:22:14 -07:00
Todd C. Miller
dd5f7a4505 No need for sudo_fatalx() here, just pass back an error. 2023-11-11 08:31:23 -07:00
Todd C. Miller
2c06aa321b cvtsudoers_ldif: display warning on write error 2023-11-11 08:19:19 -07:00
Todd C. Miller
7e4632691b cvtsudoers_merge.c: remove sudo_fatal() calls. 
Errors are now propagated up the call stack.
 2023-11-11 08:15:06 -07:00
Todd C. Miller
8cfd4467f4 Make new_member() return NULL on failure and adjust callers. 2023-11-10 16:53:57 -07:00
Todd C. Miller
564d8ac01d Pass return values back instead of using sudo_fatal(). 2023-11-10 14:05:35 -07:00
Todd C. Miller
d28884b1c7 Add printf_attribute_ldif() to printf-format an LDIF attribute. 
This replaces multiple sequences of asprintf() and print_attribute_ldif().
 2023-11-10 13:34:13 -07:00
Todd C. Miller
12e55dcd78 cvtsudoers_json.c: check sudo_json_* return values. 
Previously, we set memfatal to true in sudo_json_init() instead.
This also gets rid of a number of sudo_fatalx() calls.
 2023-11-09 17:12:56 -07:00
Todd C. Miller
1a68935ae3 add_timestamp: check sudo_json_* return values. 2023-11-09 17:12:55 -07:00
Todd C. Miller
a2998a6701 alias_apply: change return type to bool 
We can use the rbapply() return value to detect failure.
 2023-11-09 15:31:26 -07:00
Todd C. Miller
e0d912d1db Use C99 designated struct initializers. 
This is less error-prone and would have avoided GitHub issue #325.
 2023-11-07 14:47:48 -07:00
Todd C. Miller
87c193f3f9 Correct the order of the strings in SUDOERS_CONTEXT_INITIALIZER. 
Fixes GitHub issue #325, a bug introduced in sudo 1.9.15.
 2023-11-07 13:38:30 -07:00
Todd C. Miller
24351bdadc sudo_set_grlist and sudo_set_gidlist: set auth registry based on username 
Previously we used the global registry but since we have the user's
passwd info we should use that when storing the group and gid lists.
 2023-11-03 10:30:56 -06:00
Todd C. Miller
2ffcda8e15 role_to_sudoers: only try to reuse a privilege if one is present 2023-11-02 14:42:42 -06:00
Todd C. Miller
1a11be4d9f store_plugin: avoid potential NULL deref in boolean context 
Coverity CID 330466
 2023-11-02 14:26:44 -06:00
Todd C. Miller
4833ac0f01 Avoid passing sudo_term_is_raw() -1 for the fd. 
Coverity CID 330472
Coverity CID 330468
 2023-11-02 14:17:51 -06:00