isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a crash in make_grlist_item() on 64-bit machines with strict

Browse Source 
alignment.
This commit is contained in:
Todd C. Miller
2011-09-16 09:05:37 -04:00
parent cab1968da2
commit fd2d709bd2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/pwutil.c
View File

@@ -508,16 +508,16 @@ make_grlist_item(const char *user, GETGROUPS_T *gids, int ngids)
/* /*
* Copy in group list and make pointers relative to space * Copy in group list and make pointers relative to space
* at the end of the buffer. Note that the gids array must come * at the end of the buffer. Note that the groups array must come
* immediately after struct group to guarantee proper alignment. * immediately after struct group to guarantee proper alignment.
*/ */
grlist = (struct group_list *)cp; grlist = (struct group_list *)cp;
zero_bytes(grlist, sizeof(struct group_list)); zero_bytes(grlist, sizeof(struct group_list));
cp += sizeof(struct group_list); cp += sizeof(struct group_list);
grlist->gids = (gid_t *)cp;
cp += sizeof(gid_t) * ngids;
grlist->groups = (char **)cp; grlist->groups = (char **)cp;
cp += sizeof(char *) * ngids; cp += sizeof(char *) * ngids;
grlist->gids = (gid_t *)cp;
cp += sizeof(gid_t) * ngids;
/* Set key and datum. */ /* Set key and datum. */
memcpy(cp, user, nsize); memcpy(cp, user, nsize);