isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some dead stores noted by PVS Studio.

Browse Source 
Since rc is initialized to SUDO_RC_ERROR there is no need to set
it to SUDO_RC_ERROR again on failure if rc has not been changed
since initialization.
This commit is contained in:
Todd C. Miller
2022-12-11 13:46:04 -07:00
parent a04557c3d4
commit f26a2e7626
4 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/python/python_plugin_audit.c
View File

@@ -62,8 +62,6 @@ _call_plugin_open(struct AuditPluginContext *audit_ctx, int submit_optind, char
if (py_submit_argv != NULL) {
rc = python_plugin_api_rc_call(plugin_ctx, CALLBACK_PYNAME(open),
Py_BuildValue("(iO)", submit_optind, py_submit_argv));
} else {
rc = SUDO_RC_ERROR;
}
Py_XDECREF(py_submit_argv);

1
plugins/python/python_plugin_common.c
View File

@@ -309,7 +309,6 @@ python_plugin_construct(struct PluginContext *plugin_ctx, unsigned int version,
if (py_kwargs == NULL) {
py_log_last_error("Failed to construct plugin instance");
rc = SUDO_RC_ERROR;
} else {
rc = python_plugin_construct_custom(plugin_ctx, py_kwargs);
}

2
plugins/python/python_plugin_io.c
View File

@@ -64,8 +64,6 @@ _call_plugin_open(struct IOPluginContext *io_ctx, int argc, char * const argv[],
if (py_argv != NULL && py_command_info != NULL) {
rc = python_plugin_api_rc_call(plugin_ctx, CALLBACK_PYNAME(open),
Py_BuildValue("(OO)", py_argv, py_command_info));
} else {
rc = SUDO_RC_ERROR;
}
if (rc != SUDO_RC_OK)

1
plugins/python/python_plugin_policy.c
View File

@@ -132,7 +132,6 @@ python_plugin_policy_check(int argc, char * const argv[],
&PyTuple_Type, &py_argv_out,
&PyTuple_Type, &py_user_env_out))
{
rc = SUDO_RC_ERROR;
goto cleanup;
}
} else {