isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better warning when close function is passed a non-terminal signal.

Browse Source
This commit is contained in:
Todd C. Miller
2021-05-10 13:45:25 -06:00
parent 0f5c8fe121
commit f2155c704f
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/sudoers/log_client.c
View File

@@ -1196,7 +1196,7 @@ fmt_exit_message(struct client_closure *closure, int exit_status, int error)
if (WIFEXITED(exit_status)) { if (WIFEXITED(exit_status)) {
exit_msg.exit_value = WEXITSTATUS(exit_status); exit_msg.exit_value = WEXITSTATUS(exit_status);
} else if (WIFSIGNALED(exit_status)) { } else if (WIFSIGNALED(exit_status)) {
int signo = WTERMSIG(exit_status); const int signo = WTERMSIG(exit_status);
if (signo <= 0 || sig2str(signo, signame) == -1) { if (signo <= 0 || sig2str(signo, signame) == -1) {
sudo_warnx(U_("%s: internal error, invalid signal %d"), sudo_warnx(U_("%s: internal error, invalid signal %d"),
__func__, signo); __func__, signo);
@@ -1206,6 +1206,15 @@ fmt_exit_message(struct client_closure *closure, int exit_status, int error)
if (WCOREDUMP(exit_status)) if (WCOREDUMP(exit_status))
exit_msg.dumped_core = true; exit_msg.dumped_core = true;
exit_msg.exit_value = WTERMSIG(exit_status) | 128; exit_msg.exit_value = WTERMSIG(exit_status) | 128;
} else if (WIFSTOPPED(exit_status)) {
const int signo = WSTOPSIG(exit_status);
sudo_warnx(U_("%s: internal error, invalid signal %d"),
__func__, signo);
goto done;
} else if (WIFCONTINUED(exit_status)) {
sudo_warnx(U_("%s: internal error, invalid signal %d"),
__func__, SIGCONT);
goto done;
} else { } else {
sudo_warnx(U_("%s: internal error, invalid exit status %d"), sudo_warnx(U_("%s: internal error, invalid exit status %d"),
__func__, exit_status); __func__, exit_status);