isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer VISUAL over EDITOR like old vipw did.

Browse Source
This commit is contained in:
Todd C. Miller
2004-01-20 19:18:44 +00:00
parent 3001e7f296
commit f068ee01c4
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
visudo.c
View File

@@ -246,13 +246,13 @@ main(argc, argv)
(void) close(stmp_fd); (void) close(stmp_fd);
/* /*
* Check EDITOR and VISUAL environment variables to see which editor * Check VISUAL and EDITOR environment variables to see which editor
* the user wants to use (we may not end up using it though). * the user wants to use (we may not end up using it though).
* If the path is not fully-qualified, make it so and check that * If the path is not fully-qualified, make it so and check that
* the specified executable actually exists. * the specified executable actually exists.
*/ */
if ((UserEditor = getenv("EDITOR")) == NULL || *UserEditor == '\0') if ((UserEditor = getenv("VISUAL")) == NULL || *UserEditor == '\0')
UserEditor = getenv("VISUAL"); UserEditor = getenv("EDITOR");
if (UserEditor && *UserEditor == '\0') if (UserEditor && *UserEditor == '\0')
UserEditor = NULL; UserEditor = NULL;
else if (UserEditor) { else if (UserEditor) {

10
visudo.pod
View File

@@ -59,13 +59,13 @@ There is a hard-coded list of editors that B<visudo> will use set
at compile-time that may be overridden via the I<editor> I<sudoers> at compile-time that may be overridden via the I<editor> I<sudoers>
C<Default> variable. This list defaults to the path to vi(1) on C<Default> variable. This list defaults to the path to vi(1) on
your system, as determined by the I<configure> script. Normally, your system, as determined by the I<configure> script. Normally,
B<visudo> does not honor the C<EDITOR> or C<VISUAL> environment B<visudo> does not honor the C<VISUAL> or C<EDITOR> environment
variables unless they contain an editor in the aforementioned editors variables unless they contain an editor in the aforementioned editors
list. However, if B<visudo> is configured with the I<--with-enveditor> list. However, if B<visudo> is configured with the I<--with-enveditor>
flag or the I<enveditor> C<Default> variable is set in I<sudoers>, flag or the I<enveditor> C<Default> variable is set in I<sudoers>,
B<visudo> will use any the editor defines by C<EDITOR> or C<VISUAL>. B<visudo> will use any the editor defines by C<VISUAL> or C<EDITOR>.
Note that this can be a security hole since it allows the user to Note that this can be a security hole since it allows the user to
execute any program they wish simply by setting C<EDITOR> or C<VISUAL>. execute any program they wish simply by setting C<VISUAL> or C<EDITOR>.
B<visudo> parses the I<sudoers> file after the edit and will B<visudo> parses the I<sudoers> file after the edit and will
not save the changes if there is a syntax error. Upon finding not save the changes if there is a syntax error. Upon finding
@@ -156,8 +156,8 @@ mode these are errors, not warnings.
The following environment variables are used only if B<visudo> The following environment variables are used only if B<visudo>
was configured with the I<--with-env-editor> option: was configured with the I<--with-env-editor> option:
EDITOR Invoked by visudo as the editor to use VISUAL Invoked by visudo as the editor to use
VISUAL Used by visudo if EDITOR is not set EDITOR Used by visudo if VISUAL is not set
=head1 FILES =head1 FILES