isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't try to fflush(export_fp) or ferror(export_fp) if export_fp

Browse Source 
is NULL, which can happen on the error path.
This commit is contained in:
Todd C. Miller
2016-05-16 14:16:08 -06:00
parent a2e541aef8
commit eb4510597b
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/sudoers/visudo_json.c
View File

@@ -1062,10 +1062,12 @@ export_sudoers(const char *sudoers_path, const char *export_path,
fputs("\n}\n", export_fp);
done:
(void)fflush(export_fp);
if (ferror(export_fp))
rval = false;
if (export_fp != stdout && export_fp != NULL)
fclose(export_fp);
if (export_fp != NULL) {
(void)fflush(export_fp);
if (ferror(export_fp))
rval = false;
if (export_fp != stdout)
fclose(export_fp);
}
debug_return_bool(rval);
}