isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use calloc() instead of malloc(n * s) followed by memset().

Browse Source 
From Jean-Philippe Ouellet.
This commit is contained in:
Todd C. Miller
2014-04-22 16:06:04 -06:00
parent 62a278183b
commit e8bb08cc46
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/CONTRIBUTORS
View File

@@ -99,6 +99,7 @@ you believe you should be listed, please send a note to sudo@sudo.ws.
Nieusma, Jeff Nieusma, Jeff
Nikitser, Peter A. Nikitser, Peter A.
Nussel, Ludwig Nussel, Ludwig
Ouellet, Jean-Philippe
Paquet, Eric Paquet, Eric
Paradis, Chantal Paradis, Chantal
Percival, Ted Percival, Ted

3
plugins/sudoers/auth/pam.c
View File

@@ -315,9 +315,8 @@ converse(int num_msg, PAM_CONST struct pam_message **msg,
int ret = PAM_AUTH_ERR; int ret = PAM_AUTH_ERR;
debug_decl(converse, SUDO_DEBUG_AUTH) debug_decl(converse, SUDO_DEBUG_AUTH)
if ((*response = malloc(num_msg * sizeof(struct pam_response))) == NULL) if ((*response = calloc(num_msg, sizeof(struct pam_response))) == NULL)
debug_return_int(PAM_SYSTEM_ERR); debug_return_int(PAM_SYSTEM_ERR);
memset(*response, 0, num_msg * sizeof(struct pam_response));
for (pr = *response, pm = *msg, n = num_msg; n--; pr++, pm++) { for (pr = *response, pm = *msg, n = num_msg; n--; pr++, pm++) {
type = SUDO_CONV_PROMPT_ECHO_OFF; type = SUDO_CONV_PROMPT_ECHO_OFF;