isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pasto/thinko in setresgid()/setregid() usage.

Browse Source 
Want to set effective gid, not real gid, when reading sudoers.
This commit is contained in:
Todd C. Miller
2002-12-15 16:24:24 +00:00
parent 1996179bf2
commit e27e963f2b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
set_perms.c
View File

@@ -175,7 +175,7 @@ set_perms_suid(perm)
break; break;
case PERM_USER: case PERM_USER:
(void) setresgid(user_gid, -1, -1); (void) setresgid(-1, user_gid, -1);
if (setresuid(user_uid, user_uid, 0)) if (setresuid(user_uid, user_uid, 0))
fatal("setresuid(user_uid, user_uid, 0)", 1); fatal("setresuid(user_uid, user_uid, 0)", 1);
break; break;
@@ -199,7 +199,7 @@ set_perms_suid(perm)
case PERM_SUDOERS: case PERM_SUDOERS:
/* assume euid == 0, ruid == user */ /* assume euid == 0, ruid == user */
if (setresgid(SUDOERS_GID, -1, -1)) if (setresgid(-1, SUDOERS_GID, -1))
fatal("unable to change to sudoers gid", 1); fatal("unable to change to sudoers gid", 1);
/* /*
@@ -247,7 +247,7 @@ set_perms_suid(perm)
break; break;
case PERM_USER: case PERM_USER:
(void) setregid(user_gid, -1); (void) setregid(-1, user_gid);
if (setreuid(0, user_uid)) if (setreuid(0, user_uid))
fatal("setreuid(0, user_uid)", 1); fatal("setreuid(0, user_uid)", 1);
break; break;
@@ -271,7 +271,7 @@ set_perms_suid(perm)
case PERM_SUDOERS: case PERM_SUDOERS:
/* assume euid == 0, ruid == user */ /* assume euid == 0, ruid == user */
if (setregid(SUDOERS_GID, -1)) if (setregid(-1, SUDOERS_GID))
fatal("unable to change to sudoers gid", 1); fatal("unable to change to sudoers gid", 1);
/* /*