isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delay calling the I/O plugin open function until the policy plugin

Browse Source 
returns success.
This commit is contained in:
Todd C. Miller
2010-03-28 08:41:06 -04:00
parent 05e8023e78
commit e17f1e5cbd
2 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/parse_args.c
View File

@@ -401,7 +401,7 @@ parse_args(int argc, char **argv, int *nargc, char ***nargv, char ***settingsp,
/* /*
* Format setting_pairs into settings array. * Format setting_pairs into settings array.
*/ */
settings = emalloc2(NUM_SETTINGS + 1, sizeof (char *)); settings = emalloc2(NUM_SETTINGS + 1, sizeof(char *));
for (i = 0, j = 0; i < NUM_SETTINGS; i++) { for (i = 0, j = 0; i < NUM_SETTINGS; i++) {
if (sudo_settings[i].value) { if (sudo_settings[i].value) {
sudo_debug(9, "settings: %s=%s", sudo_settings[i].name, sudo_debug(9, "settings: %s=%s", sudo_settings[i].name,

27
src/sudo.c
View File

@@ -162,22 +162,11 @@ main(int argc, char *argv[], char *envp[])
/* Read sudo.conf and load plugins. */ /* Read sudo.conf and load plugins. */
sudo_load_plugins(_PATH_SUDO_CONF, &policy_plugin, &io_plugins); sudo_load_plugins(_PATH_SUDO_CONF, &policy_plugin, &io_plugins);
/* Open each plugin. */ /* Open policy plugin. */
ok = policy_plugin.u.policy->open(SUDO_API_VERSION, sudo_conversation, ok = policy_plugin.u.policy->open(SUDO_API_VERSION, sudo_conversation,
settings, user_info, envp); settings, user_info, envp);
if (ok != TRUE) if (ok != TRUE)
errorx(1, "unable to initialize policy plugin"); errorx(1, "unable to initialize policy plugin");
for (plugin = io_plugins.first; plugin != NULL; plugin = next) {
next = plugin->next;
ok = plugin->u.io->open(SUDO_API_VERSION, sudo_conversation, settings,
user_info, envp);
if (ok == -1)
errorx(1, "error initializing I/O plugin %s", plugin->name);
if (!ok) {
/* Disable I/O plugin by removing it from the list. */
tq_remove(&io_plugins, plugin);
}
}
sudo_debug(9, "sudo_mode %d", sudo_mode); sudo_debug(9, "sudo_mode %d", sudo_mode);
switch (sudo_mode & MODE_MASK) { switch (sudo_mode & MODE_MASK) {
@@ -229,12 +218,24 @@ main(int argc, char *argv[], char *envp[])
usage(1); usage(1);
exit(1); /* plugin printed error message */ exit(1); /* plugin printed error message */
} }
/* Open I/O plugins once policy plugin succeeds. */
for (plugin = io_plugins.first; plugin != NULL; plugin = next) {
next = plugin->next;
ok = plugin->u.io->open(SUDO_API_VERSION, sudo_conversation, settings,
user_info, envp);
if (ok == -1)
errorx(1, "error initializing I/O plugin %s", plugin->name);
if (!ok) {
/* I/O plugin asked to be disabled, remove from list. */
tq_remove(&io_plugins, plugin);
}
}
command_info_to_details(command_info, &command_details); command_info_to_details(command_info, &command_details);
/* Restore coredumpsize resource limit before running. */ /* Restore coredumpsize resource limit before running. */
#if defined(RLIMIT_CORE) && !defined(SUDO_DEVEL) #if defined(RLIMIT_CORE) && !defined(SUDO_DEVEL)
(void) setrlimit(RLIMIT_CORE, &corelimit); (void) setrlimit(RLIMIT_CORE, &corelimit);
#endif /* RLIMIT_CORE && !SUDO_DEVEL */ #endif /* RLIMIT_CORE && !SUDO_DEVEL */
/* run_command will call close for us */ /* run_command will call the close method for us */
run_command(&command_details, argv_out, user_env_out); run_command(&command_details, argv_out, user_env_out);
break; break;
case MODE_EDIT: case MODE_EDIT: