isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reject relative command paths if runcwd is not set.

Browse Source 
This is now treated as a policy rejection.
This commit is contained in:
Todd C. Miller
2022-07-26 11:04:29 -06:00
parent 16ea0bb3fd
commit de3d5fe934
1 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/exec_intercept.c
View File

@@ -373,12 +373,28 @@ intercept_check_policy(const char *command, int argc, char **argv, int envc,
debug_decl(intercept_check_policy, SUDO_DEBUG_EXEC);
if (ISSET(closure->details->flags, CD_INTERCEPT)) {
/* Change to runcwd for the policy check if possible. */
if (runcwd != NULL) {
saved_dir = open(".", O_RDONLY);
if (saved_dir != -1 && chdir(runcwd) == -1) {
sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_ERRNO,
"%s: unable to chdir to %s", __func__, runcwd);
/* Change to runcwd for the policy check if necessary. */
if (*command != '/') {
if (runcwd == NULL || (saved_dir = open(".", O_RDONLY)) == -1 ||
chdir(runcwd) == -1) {
if (runcwd == NULL) {
sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_LINENO,
"relative command path but no runcwd specified");
} else if (saved_dir == -1) {
sudo_debug_printf(
SUDO_DEBUG_ERROR|SUDO_DEBUG_LINENO|SUDO_DEBUG_ERRNO,
"unable to open current directory for reading");
} else {
sudo_debug_printf(
SUDO_DEBUG_ERROR|SUDO_DEBUG_LINENO|SUDO_DEBUG_ERRNO,
"unable to chdir for %s", runcwd);
}
if (closure->errstr == NULL)
closure->errstr = N_("command rejected by policy");
audit_reject(policy_plugin.name, SUDO_POLICY_PLUGIN,
closure->errstr, closure->details->info);
closure->state = POLICY_REJECT;
goto done;
}
}