From d65bcf2ab35c068df6330a64ee13da35b8834aac Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Thu, 18 Aug 2022 10:27:01 -0600 Subject: [PATCH] Avoid a Coverity false positive. --- plugins/sudoers/match_digest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sudoers/match_digest.c b/plugins/sudoers/match_digest.c index 1763e8e30..f1655951e 100644 --- a/plugins/sudoers/match_digest.c +++ b/plugins/sudoers/match_digest.c @@ -105,9 +105,9 @@ digest_matches(int fd, const char *path, const char *runchroot, } else { /* Convert base64 to binary. */ size_t len = base64_decode(digest->digest_str, sudoers_digest, digest_len); + if (len == (size_t)-1) + goto bad_format; if (len != digest_len) { - if (len == (size_t)-1) - goto bad_format; sudo_warnx( U_("digest for %s (%s) bad length %zu, expected %zu"), path, digest->digest_str, len, digest_len);