isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

In exec_setup() call setuid(0) to make certain the subsequent

Browse Source 
uid and gid changes will succeed.  Fixes a problem on Ubuntu.
This commit is contained in:
Todd C. Miller
2010-11-23 07:26:21 -05:00
parent d869ca1f90
commit d39747e6a5
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/sudo.c
View File

@@ -730,6 +730,14 @@ exec_setup(struct command_details *details, const char *ptyname, int ptyfd)
int rval = FALSE; int rval = FALSE;
struct passwd *pw; struct passwd *pw;
/*
* This function must run with root privileges.
*/
if (setuid(ROOT_UID) != 0) {
warning("unable to change to uid to root (%u)", ROOT_UID);
goto done;
}
#ifdef HAVE_SETAUTHDB #ifdef HAVE_SETAUTHDB
aix_setauthdb(IDtouser(details->euid)); aix_setauthdb(IDtouser(details->euid));
#endif #endif
@@ -791,12 +799,12 @@ exec_setup(struct command_details *details, const char *ptyname, int ptyfd)
*/ */
#ifdef HAVE_SETEUID #ifdef HAVE_SETEUID
if (ISSET(details->flags, CD_SET_EGID) && setegid(details->egid)) { if (ISSET(details->flags, CD_SET_EGID) && setegid(details->egid)) {
warning("unable to set egid to runas gid"); warning("unable to set egid to runas gid %u", details->egid);
goto done; goto done;
} }
#endif #endif
if (ISSET(details->flags, CD_SET_GID) && setgid(details->gid)) { if (ISSET(details->flags, CD_SET_GID) && setgid(details->gid)) {
warning("unable to set gid to runas gid"); warning("unable to set gid to runas gid %u", details->gid);
goto done; goto done;
} }
@@ -833,17 +841,20 @@ exec_setup(struct command_details *details, const char *ptyname, int ptyfd)
#ifdef HAVE_SETRESUID #ifdef HAVE_SETRESUID
if (setresuid(details->uid, details->euid, details->euid) != 0) { if (setresuid(details->uid, details->euid, details->euid) != 0) {
warning("unable to change to runas uid"); warning("unable to change to runas uid (%u, %u)", details->uid,
details->euid);
goto done; goto done;
} }
#elif HAVE_SETREUID #elif HAVE_SETREUID
if (setreuid(details->uid, details->euid) != 0) { if (setreuid(details->uid, details->euid) != 0) {
warning("unable to change to runas uid"); warning("unable to change to runas uid (%u, %u)", details->uid,
details->euid);
goto done; goto done;
} }
#else #else
if (seteuid(details->euid) != 0 || setuid(details->euid) != 0) { if (seteuid(details->euid) != 0 || setuid(details->euid) != 0) {
warning("unable to change to runas uid"); warning("unable to change to runas uid (%u, %u)", details->uid,
details->euid);
goto done; goto done;
} }
#endif /* !HAVE_SETRESUID && !HAVE_SETREUID */ #endif /* !HAVE_SETRESUID && !HAVE_SETREUID */