Sync with OpenBSD version

lib/util/strlcat.c

@@ -1,7 +1,7 @@
 /*	$OpenBSD: strlcat.c,v 1.8 2001/05/13 15:40:15 deraadt Exp $	*/
 
 /*
- * Copyright (c) 1998, 2003-2005, 2010-2011, 2013, 2014
+ * Copyright (c) 1998, 2003-2005, 2010-2011, 2013-2015
  *	Todd C. Miller <Todd.Miller@courtesan.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
@@ -27,37 +27,37 @@
 #include "sudo_compat.h"
 
 /*
- * Appends src to string dst of size siz (unlike strncat, siz is the
+ * Appends src to string dst of size dsize (unlike strncat, dsize is the
- * full size of dst, not space left).  At most siz-1 characters
+ * full size of dst, not space left).  At most dsize-1 characters
- * will be copied.  Always NUL terminates (unless siz <= strlen(dst)).
+ * will be copied.  Always NUL terminates (unless dsize <= strlen(dst)).
- * Returns strlen(src) + MIN(siz, strlen(initial dst)).
+ * Returns strlen(src) + MIN(dsize, strlen(initial dst)).
  * If retval >= siz, truncation occurred.
  */
 size_t
-sudo_strlcat(char *dst, const char *src, size_t siz)
+sudo_strlcat(char *dst, const char *src, size_t dsize)
 {
-	char *d = dst;
+	const char *odst = dst;
-	const char *s = src;
+	const char *osrc = src;
-	size_t n = siz;
+	size_t n = dsize;
 	size_t dlen;
 
-	/* Find the end of dst and adjust bytes left but don't go past end */
+	/* Find the end of dst and adjust bytes left but don't go past end. */
-	while (n-- != 0 && *d != '\0')
+	while (n-- != 0 && *dst != '\0')
-		d++;
+		dst++;
-	dlen = d - dst;
+	dlen = dst - odst;
-	n = siz - dlen;
+	n = dsize - dlen;
 
-	if (n == 0)
+	if (n-- == 0)
-		return dlen + strlen(s);
+		return(dlen + strlen(src));
-	while (*s != '\0') {
+	while (*src != '\0') {
-		if (n != 1) {
+		if (n != 0) {
-			*d++ = *s;
+			*dst++ = *src;
 			n--;
 		}
-		s++;
+		src++;
 	}
-	*d = '\0';
+	*dst = '\0';
 
-	return dlen + (s - src);	/* count does not include NUL */
+	return(dlen + (src - osrc));	/* count does not include NUL */
 }
 #endif /* HAVE_STRLCAT */

lib/util/strlcpy.c

@@ -1,7 +1,7 @@
 /*	$OpenBSD: strlcpy.c,v 1.5 2001/05/13 15:40:16 deraadt Exp $	*/
 
 /*
- * Copyright (c) 1998, 2003-2005, 2010-2011, 2013, 2014
+ * Copyright (c) 1998, 2003-2005, 2010-2011, 2013-2015
  *	Todd C. Miller <Todd.Miller@courtesan.com>
  *
  * Permission to use, copy, modify, and distribute this software for any
@@ -26,33 +26,32 @@
 #include "sudo_compat.h"
 
 /*
- * Copy src to string dst of size siz.  At most siz-1 characters
+ * Copy string src to buffer dst of size dsize.  At most dsize-1
- * will be copied.  Always NUL terminates (unless siz == 0).
+ * chars will be copied.  Always NUL terminates (unless dsize == 0).
- * Returns strlen(src); if retval >= siz, truncation occurred.
+ * Returns strlen(src); if retval >= dsize, truncation occurred.
  */
 size_t
-sudo_strlcpy(char *dst, const char *src, size_t siz)
+sudo_strlcpy(char *dst, const char *src, size_t dsize)
 {
-	char *d = dst;
+	const char *osrc = src;
-	const char *s = src;
+	size_t nleft = dsize;
-	size_t n = siz;
 
-	/* Copy as many bytes as will fit */
+	/* Copy as many bytes as will fit. */
-	if (n != 0 && --n != 0) {
+	if (nleft != 0) {
-		do {
+		while (--nleft != 0) {
-			if ((*d++ = *s++) == 0)
+			if ((*dst++ = *src++) == '\0')
 				break;
-		} while (--n != 0);
+		}
 	}
 
-	/* Not enough room in dst, add NUL and traverse rest of src */
+	/* Not enough room in dst, add NUL and traverse rest of src. */
-	if (n == 0) {
+	if (nleft == 0) {
-		if (siz != 0)
+		if (dsize != 0)
-			*d = '\0';		/* NUL-terminate dst */
+			*dst = '\0';		/* NUL-terminate dst */
-		while (*s++)
+		while (*src++)
 			;
 	}
 
-	return s - src - 1;	/* count does not include NUL */
+	return(src - osrc - 1);	/* count does not include NUL */
 }
 #endif /* HAVE_STRLCPY */