isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Parse "ALL" as a command correctly.

Browse Source
This commit is contained in:
Todd C. Miller
2018-05-14 08:35:48 -06:00
parent 4a3aa5f6e6
commit cc3428398a
1 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
plugins/sudoers/ldap_util.c
View File

@@ -324,28 +324,32 @@ sudo_ldap_role_to_priv(const char *cn, void *hosts, void *runasusers,
cmndspec->timeout = UNSPEC; cmndspec->timeout = UNSPEC;
/* Fill in member. */ /* Fill in member. */
m->type = COMMAND;
m->negated = negated; m->negated = negated;
m->name = (char *)c; if (strcmp(cmnd, "ALL") == 0) {
m->type = ALL;
} else {
m->type = COMMAND;
m->name = (char *)c;
/* Fill in command with optional digest. */ /* Fill in command with optional digest. */
if (sudo_ldap_extract_digest(&cmnd, &digest) != NULL) { if (sudo_ldap_extract_digest(&cmnd, &digest) != NULL) {
if ((c->digest = malloc(sizeof(*c->digest))) == NULL) { if ((c->digest = malloc(sizeof(*c->digest))) == NULL) {
free_member(m);
goto oom;
}
*c->digest = digest;
}
if ((args = strpbrk(cmnd, " \t")) != NULL) {
*args++ = '\0';
if ((c->args = strdup(args)) == NULL) {
free_member(m);
goto oom;
}
}
if ((c->cmnd = strdup(cmnd)) == NULL) {
free_member(m); free_member(m);
goto oom; goto oom;
} }
*c->digest = digest;
}
if ((args = strpbrk(cmnd, " \t")) != NULL) {
*args++ = '\0';
if ((c->args = strdup(args)) == NULL) {
free_member(m);
goto oom;
}
}
if ((c->cmnd = strdup(cmnd)) == NULL) {
free_member(m);
goto oom;
} }
cmndspec->cmnd = m; cmndspec->cmnd = m;