isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cast int to size_t before adding instead of casting the result.

Browse Source 
Quiets PVS-Studio warning V1028.
This commit is contained in:
Todd C. Miller
2023-08-21 12:50:31 -06:00
parent 9f05bfd298
commit c6987aa26e
6 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/exec_ptrace.c
View File

@@ -1884,7 +1884,7 @@ ptrace_intercept_execve(pid_t pid, struct intercept_closure *closure)
*/
if (argv_mismatch) {
/* argv pointers */
space += (size_t)(argc + 1 + regs.compat) * regs.wordsize;
space += ((size_t)argc + 1 + regs.compat) * regs.wordsize;
/* argv strings */
for (argc = 0; closure->run_argv[argc] != NULL; argc++) {
@@ -1905,7 +1905,7 @@ ptrace_intercept_execve(pid_t pid, struct intercept_closure *closure)
set_sc_arg2(&regs, sp);
/* Skip over argv pointers (plus NULL) for string table. */
strtab += (size_t)(argc + 1 + regs.compat) * regs.wordsize;
strtab += ((size_t)argc + 1 + regs.compat) * regs.wordsize;
nwritten = ptrace_write_vec(pid, &regs, closure->run_argv,
sp, strtab);