isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only display "unable to connect to log server" warning once.

Browse Source 
Previously, in intercept mode, if the log server is unreachable the
message would be printed for each sub-command.
This commit is contained in:
Todd C. Miller
2022-05-31 20:03:17 -06:00
parent de4d53e488
commit c20c3b5631
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/log_client.c
View File

@@ -2011,6 +2011,7 @@ log_server_open(struct log_details *details, struct timespec *now,
struct sudo_plugin_event * (*event_alloc)(void)) struct sudo_plugin_event * (*event_alloc)(void))
{ {
struct client_closure *closure; struct client_closure *closure;
static bool warned = false;
debug_decl(log_server_open, SUDOERS_DEBUG_UTIL); debug_decl(log_server_open, SUDOERS_DEBUG_UTIL);
closure = client_closure_alloc(details, now, log_io, initial_state, closure = client_closure_alloc(details, now, log_io, initial_state,
@@ -2021,7 +2022,10 @@ log_server_open(struct log_details *details, struct timespec *now,
/* Connect to log first available log server. */ /* Connect to log first available log server. */
if (!log_server_connect(closure)) { if (!log_server_connect(closure)) {
/* TODO: support offline logs if server unreachable */ /* TODO: support offline logs if server unreachable */
sudo_warnx("%s", U_("unable to connect to log server")); if (!warned) {
sudo_warnx("%s", U_("unable to connect to log server"));
warned = true;
}
goto bad; goto bad;
} }