isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Must call audit_success before we change uids.

Browse Source
This commit is contained in:
Todd C. Miller
2009-05-10 11:59:53 +00:00
parent 755a81e946
commit c0ac222c3f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sudo.c
View File

@@ -482,6 +482,9 @@ main(argc, argv, envp)
(void) setrlimit(RLIMIT_CORE, &corelimit); (void) setrlimit(RLIMIT_CORE, &corelimit);
#endif /* RLIMIT_CORE && !SUDO_DEVEL */ #endif /* RLIMIT_CORE && !SUDO_DEVEL */
/* Must audit before uid change. */
audit_success(NewArgv);
/* Become specified user or root if executing a command. */ /* Become specified user or root if executing a command. */
if (ISSET(sudo_mode, MODE_RUN)) if (ISSET(sudo_mode, MODE_RUN))
set_perms(PERM_FULL_RUNAS); set_perms(PERM_FULL_RUNAS);
@@ -529,7 +532,6 @@ main(argc, argv, envp)
#ifndef PROFILING #ifndef PROFILING
if (ISSET(sudo_mode, MODE_BACKGROUND) && fork() > 0) { if (ISSET(sudo_mode, MODE_BACKGROUND) && fork() > 0) {
syslog(LOG_AUTH|LOG_ERR, "fork"); syslog(LOG_AUTH|LOG_ERR, "fork");
audit_success(NewArgv);
exit(0); exit(0);
} else { } else {
#ifdef HAVE_SELINUX #ifdef HAVE_SELINUX
@@ -537,7 +539,6 @@ main(argc, argv, envp)
selinux_exec(user_role, user_type, NewArgv, selinux_exec(user_role, user_type, NewArgv,
ISSET(sudo_mode, MODE_LOGIN_SHELL)); ISSET(sudo_mode, MODE_LOGIN_SHELL));
#endif #endif
audit_success(NewArgv);
execv(safe_cmnd, NewArgv); execv(safe_cmnd, NewArgv);
} }
#else #else