isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add free_default() to free a struct defaults pointer so we have a

Browse Source 
single place where we free the defaults.  A pointer to the previous
Default's binding may be passed in to avoid freeing an already free
binding.
This commit is contained in:
Todd C. Miller
2018-03-21 12:11:19 -06:00
parent b6c53ac846
commit bc5e2d06a7
4 changed files with 80 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/defaults.c
View File

@@ -457,7 +457,7 @@ run_early_defaults(void)
}
static void
free_default(int type, union sudo_defs_val *sd_un)
free_defs_val(int type, union sudo_defs_val *sd_un)
{
switch (type & T_MASK) {
case T_STR:
@@ -484,7 +484,7 @@ init_defaults(void)
/* Clear any old settings. */
if (!firsttime) {
for (def = sudo_defs_table; def->name != NULL; def++)
free_default(def->type, &def->sd_un);
free_defs_val(def->type, &def->sd_un);
}
/* First initialize the flags. */
@@ -800,7 +800,7 @@ check_defaults(bool quiet)
memset(&sd_un, 0, sizeof(sd_un));
if (parse_default_entry(def, d->val, d->op, &sd_un, d->file,
d->lineno, quiet)) {
free_default(def->type, &sd_un);
free_defs_val(def->type, &sd_un);
continue;
}
}