isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid calling realloc3() with a zero size parameter when all retrieved

Browse Source 
sssd rules fail.  Otherwise we'll get a run-time error due to
malloc(0) checking.
This commit is contained in:
Todd C. Miller
2013-02-21 07:01:53 -05:00
parent c80603eace
commit b929dd3c46
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/sudoers/sssd.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2003-2012 Todd C. Miller <Todd.Miller@courtesan.com> * Copyright (c) 2003-2013 Todd C. Miller <Todd.Miller@courtesan.com>
* Copyright (c) 2011 Daniel Kopecek <dkopecek@redhat.com> * Copyright (c) 2011 Daniel Kopecek <dkopecek@redhat.com>
* *
* This code is derived from software contributed by Aaron Spangler. * This code is derived from software contributed by Aaron Spangler.
@@ -211,7 +211,13 @@ sudo_sss_filter_result(struct sudo_sss_handle *handle,
sudo_debug_printf(SUDO_DEBUG_DEBUG, sudo_debug_printf(SUDO_DEBUG_DEBUG,
"reallocating result: %p (count: %u -> %u)", out_res->rules, "reallocating result: %p (count: %u -> %u)", out_res->rules,
in_res->num_rules, l); in_res->num_rules, l);
out_res->rules = erealloc3(out_res->rules, l, sizeof(struct sss_sudo_rule)); if (l > 0) {
out_res->rules =
erealloc3(out_res->rules, l, sizeof(struct sss_sudo_rule));
} else {
efree(out_res->rules);
out_res->rules = NULL;
}
} }
out_res->num_rules = l; out_res->num_rules = l;