isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Py_XDECREF instead of manual NULL check + Py_DECREF

Browse Source
This commit is contained in:
Todd C. Miller
2023-07-22 08:32:17 -06:00
parent 4e6254fea2
commit b52c32f234
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/python/pyhelpers.c
View File

@@ -344,8 +344,7 @@ _py_debug_python_function(const char *class_name, const char *function_name, con
/* Strip leading RC. to match python 3.10 behavior. */
memmove(args_str, args_str + 3, strlen(args_str + 3) + 1);
}
if (py_args_sorted != NULL)
Py_DECREF(py_args_sorted);
Py_XDECREF(py_args_sorted);
}
if (py_kwargs != NULL) {
/* Sort by key for consistent output on Python < 3.6 */
@@ -359,8 +358,7 @@ _py_debug_python_function(const char *class_name, const char *function_name, con
}
}
kwargs_str = py_create_string_rep(py_kwargs);
if (py_kwargs_sorted != NULL)
Py_DECREF(py_kwargs_sorted);
Py_XDECREF(py_kwargs_sorted);
}
sudo_debug_printf(SUDO_DEBUG_DIAG, "%s.%s %s: %s%s%s\n", class_name,