isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In handler_user_only() only forward the signal if it was not generated

Browse Source 
by the command.  This should fix a problem with programs that catch
SIGTSTP, perform cleanup, and then re-send the signal to their
process group (of which sudo is the leader).
This commit is contained in:
Todd C. Miller
2014-05-27 10:51:31 -06:00
parent d628e17ead
commit b121da2e21
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/exec.c
View File

@@ -911,8 +911,13 @@ handler_user_only(int s, siginfo_t *info, void *context)
{ {
unsigned char signo = (unsigned char)s; unsigned char signo = (unsigned char)s;
/* Only forward user-generated signals. */ /*
if (info != NULL && info->si_code == SI_USER) { * Only forward user-generated signals not sent by the command.
* Signals sent by the kernel may include SIGTSTP when the user
* presses ^Z. Curses programs often trap ^Z and send SIGTSTP
* to their pgrp, so we don't want to send an extra SIGTSTP.
*/
if (info != NULL && info->si_code == SI_USER && info->si_pid != cmnd_pid) {
/* /*
* The pipe is non-blocking, if we overflow the kernel's pipe * The pipe is non-blocking, if we overflow the kernel's pipe
* buffer we drop the signal. This is not a problem in practice. * buffer we drop the signal. This is not a problem in practice.