isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Quiet clang analyzer false positive in regress tests.

Browse Source
This commit is contained in:
Todd C. Miller
2021-04-27 15:56:24 -06:00
parent 84a01d3a93
commit ac878d3e27
11 changed files with 42 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/util/regress/getgrouplist/getgrouplist_test.c
View File

@@ -91,7 +91,7 @@ main(int argc, char *argv[])
continue;
}
}
if (errors != 0) {
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}

6
lib/util/regress/tailq/hltq_test.c
View File

@@ -183,8 +183,10 @@ main(int argc, char *argv[])
}
ntests++;
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/check_symbols/check_symbols.c
View File

@@ -92,8 +92,10 @@ main(int argc, char *argv[])
sudo_dso_unload(handle);
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/editor/check_editor.c
View File

@@ -144,8 +144,10 @@ main(int argc, char *argv[])
free(edit_argv);
}
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/exptilde/check_exptilde.c
View File

@@ -96,8 +96,10 @@ main(int argc, char *argv[])
}
}
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

7
plugins/sudoers/regress/parser/check_base64.c
View File

@@ -108,7 +108,10 @@ main(int argc, char *argv[])
}
ntests *= 2; /* we test in both directions */
printf("check_base64: %d tests run, %d errors, %d%% success rate\n",
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/parser/check_fill.c
View File

@@ -175,8 +175,10 @@ main(int argc, char *argv[])
errors += do_tests(check_fill_args, args_data, nitems(args_data));
ntests = nitems(txt_data) + nitems(cmd_data) + nitems(args_data);
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/parser/check_gentime.c
View File

@@ -77,7 +77,9 @@ main(int argc, char *argv[])
errors++;
}
}
printf("check_gentime: %d tests run, %d errors, %d%% success rate\n",
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/parser/check_hexchar.c
View File

@@ -75,7 +75,9 @@ main(int argc, char *argv[])
errors++;
}
}
printf("check_hexchar: %d tests run, %d errors, %d%% success rate\n",
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/starttime/check_starttime.c
View File

@@ -111,8 +111,10 @@ main(int argc, char *argv[])
}
}
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}

6
plugins/sudoers/regress/unescape/check_unesc.c
View File

@@ -136,8 +136,10 @@ main(int argc, char *argv[])
test_strvec_join(' ', &ntests, &errors);
test_strvec_join('\n', &ntests, &errors);
printf("%s: %d tests run, %d errors, %d%% success rate\n", getprogname(),
ntests, errors, (ntests - errors) * 100 / ntests);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}