isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the "all" setting for verifypw and listpw; nopass would never

Browse Source 
be true even if all the user's entries had the NOPASSWD tag.
Regression introduce in sudo 1.8.17.  Bug #762
This commit is contained in:
Todd C. Miller
2016-11-29 19:46:25 -07:00
parent 7bcd0285e1
commit aaf6fff736
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/sudoers.c
View File

@@ -227,7 +227,7 @@ sudoers_policy_main(int argc, char * const argv[], int pwflag, char *env_add[],
char *iolog_path = NULL;
mode_t cmnd_umask = ACCESSPERMS;
struct sudo_nss *nss;
bool nopass = false;
int nopass = -1;
int cmnd_status = -1, oldlocale, validated;
int ret = -1;
debug_decl(sudoers_policy_main, SUDOERS_DEBUG_PLUGIN)
@@ -321,6 +321,8 @@ sudoers_policy_main(int argc, char * const argv[], int pwflag, char *env_add[],
case all:
if (!ISSET(validated, FLAG_NOPASSWD))
nopass = false;
else if (nopass == -1)
nopass = true;
break;
case any:
if (ISSET(validated, FLAG_NOPASSWD))
@@ -350,7 +352,7 @@ sudoers_policy_main(int argc, char * const argv[], int pwflag, char *env_add[],
break;
}
}
if (pwflag && nopass)
if (pwflag && nopass == true)
def_authenticate = false;
/* Restore user's locale. */