isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add ssizeof macro that returns ssize_t.

Browse Source 
We can use this instead of casting the result of size_t to int.
Also change checks for snprintf() returning <=0 to <0.
This commit is contained in:
Todd C. Miller
2019-06-25 09:45:10 -06:00
parent 81602ad086
commit 9d8f374397
17 changed files with 31 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/sudoers/find_path.c
View File

@@ -142,7 +142,7 @@ find_path(const char *infile, char **outfile, struct stat *sbp,
*/
len = snprintf(command, sizeof(command), "%.*s/%s",
(int)(ep - cp), cp, infile);
if (len <= 0 || len >= (int)sizeof(command)) {
if (len < 0 || len >= ssizeof(command)) {
errno = ENAMETOOLONG;
debug_return_int(NOT_FOUND_ERROR);
}
@@ -156,7 +156,7 @@ find_path(const char *infile, char **outfile, struct stat *sbp,
*/
if (!found && checkdot) {
len = snprintf(command, sizeof(command), "./%s", infile);
if (len <= 0 || len >= (int)sizeof(command)) {
if (len < 0 || len >= ssizeof(command)) {
errno = ENAMETOOLONG;
debug_return_int(NOT_FOUND_ERROR);
}