isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugins/python/regress: add a failing textcase about python plugins affect each other

Browse Source 
Since python plugins are run inside the same interpreter, they affect
each other's state, which would be better to avoid.
This commit is contained in:
Robert Manner
2020-01-24 10:01:59 +01:00
committed by Todd C. Miller
parent 5472b17516
commit 99f8394182
3 changed files with 55 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
plugins/python/regress/check_python_examples.c
View File

@@ -789,6 +789,44 @@ check_io_plugin_callbacks_are_optional(void)
return true;
}
int
check_python_plugins_do_not_affect_each_other(void)
{
// We test here that one plugin is not able to effect the environment of another
// This is important so they do not ruin or depend on each other's state.
free(data.plugin_options);
data.plugin_options = create_str_array(
4,
"ModulePath=" SRC_DIR "/regress/plugin_conflict.py",
"ClassName=ConflictPlugin",
"Path=path_for_first_plugin",
NULL
);
VERIFY_INT(python_io->open(SUDO_API_VERSION, fake_conversation, fake_printf, data.settings,
data.user_info, data.command_info, data.plugin_argc, data.plugin_argv,
data.user_env, data.plugin_options), SUDO_RC_OK);
free(data.plugin_options);
data.plugin_options = create_str_array(
4,
"ModulePath=" SRC_DIR "/regress/plugin_conflict.py",
"ClassName=ConflictPlugin",
"Path=path_for_second_plugin",
NULL
);
VERIFY_INT(python_policy->open(SUDO_API_VERSION, fake_conversation, fake_printf, data.settings,
data.user_info, data.user_env, data.plugin_options), SUDO_RC_OK);
python_io->close(0, 0);
python_policy->close(0, 0);
VERIFY_STDOUT(expected_path("check_python_plugins_do_not_affect_each_other.stdout"));
VERIFY_STR(data.stderr_str, "");
return true;
}
int
check_python_plugin_can_be_loaded(const char *python_plugin_path)
{
@@ -847,6 +885,8 @@ main(int argc, char *argv[])
RUN_TEST(check_example_policy_plugin_validate_invalidate());
RUN_TEST(check_policy_plugin_callbacks_are_optional());
RUN_TEST(check_python_plugins_do_not_affect_each_other());
RUN_TEST(check_example_debugging("plugin@err"));
RUN_TEST(check_example_debugging("plugin@info"));
RUN_TEST(check_example_debugging("load@diag"));