isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Check the return value of gettimeofday(), even though it should

Browse Source 
never fail.
This commit is contained in:
Todd C. Miller
2015-02-25 07:10:25 -07:00
parent 5d2e9426b2
commit 973286c7ac
4 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sudo_edit.c
View File

@@ -600,7 +600,10 @@ sudo_edit(struct command_details *command_details)
* Run the editor with the invoking user's creds,
* keeping track of the time spent in the editor.
*/
gettimeofday(&times[0], NULL);
if (gettimeofday(&times[0], NULL) == -1) {
sudo_warn(U_("unable to read the clock"));
goto cleanup;
}
memcpy(&saved_command_details, command_details, sizeof(struct command_details));
command_details->uid = user_details.uid;
command_details->euid = user_details.uid;
@@ -610,7 +613,10 @@ sudo_edit(struct command_details *command_details)
command_details->groups = user_details.groups;
command_details->argv = nargv;
rval = run_command(command_details);
gettimeofday(&times[1], NULL);
if (gettimeofday(&times[1], NULL) == -1) {
sudo_warn(U_("unable to read the clock"));
goto cleanup;
}
/* Restore saved command_details. */
command_details->uid = saved_command_details.uid;