isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix free() of invalid pointer introduced in the commit that stripped

Browse Source 
whitespace between a '!' and the name in a sudoOption.
This commit is contained in:
Todd C. Miller
2016-01-11 16:52:52 -07:00
parent 14b454cc0d
commit 9308d05e7e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/sssd.c
View File

@@ -1024,7 +1024,7 @@ sudo_sss_parse_options(struct sudo_sss_handle *handle, struct sss_sudo_rule *rul
{ {
int i, op; int i, op;
bool ret = false; bool ret = false;
char *cp, *v; char *copy, *cp, *v;
char **val_array = NULL; char **val_array = NULL;
debug_decl(sudo_sss_parse_options, SUDOERS_DEBUG_SSSD); debug_decl(sudo_sss_parse_options, SUDOERS_DEBUG_SSSD);
@@ -1046,7 +1046,7 @@ sudo_sss_parse_options(struct sudo_sss_handle *handle, struct sss_sudo_rule *rul
for (i = 0; val_array[i] != NULL; i++) { for (i = 0; val_array[i] != NULL; i++) {
sudo_debug_printf(SUDO_DEBUG_INFO, "sssd/ldap sudoOption: '%s'", sudo_debug_printf(SUDO_DEBUG_INFO, "sssd/ldap sudoOption: '%s'",
val_array[i]); val_array[i]);
if ((v = strdup(val_array[i])) == NULL) { if ((v = copy = strdup(val_array[i])) == NULL) {
sudo_warnx(U_("%s: %s"), __func__, U_("unable to allocate memory")); sudo_warnx(U_("%s: %s"), __func__, U_("unable to allocate memory"));
goto done; goto done;
} }
@@ -1090,7 +1090,7 @@ sudo_sss_parse_options(struct sudo_sss_handle *handle, struct sss_sudo_rule *rul
/* case var Boolean True */ /* case var Boolean True */
set_default(v, NULL, true); set_default(v, NULL, true);
} }
free(v); free(copy);
} }
ret = true; ret = true;