From 920cdf421a8beecd30e643111a0da4fdcf0bd59a Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Fri, 3 Jan 2020 04:48:56 -0700 Subject: [PATCH] Check for sudo_ev_add() failure; Coverity CID 206395 206397 --- logsrvd/sendlog.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/logsrvd/sendlog.c b/logsrvd/sendlog.c index c23f7de99..ec3e09977 100644 --- a/logsrvd/sendlog.c +++ b/logsrvd/sendlog.c @@ -1110,11 +1110,13 @@ server_msg_cb(int fd, int what, void *v) break; case SSL_ERROR_WANT_READ: /* re-schedule the read handler */ - sudo_ev_add(closure->read_ev->base, closure->read_ev, NULL, false); + if (sudo_ev_add(closure->read_ev->base, closure->read_ev, NULL, false) == -1) + sudo_warnx(U_("unable to add event to queue")); debug_return; case SSL_ERROR_WANT_WRITE: /* ssl wants to write, so schedule the write handler */ - sudo_ev_add(closure->write_ev->base, closure->write_ev, NULL, false); + if (sudo_ev_add(closure->write_ev->base, closure->write_ev, NULL, false) == -1) + sudo_warnx(U_("unable to add event to queue")); debug_return; default: break; @@ -1200,11 +1202,13 @@ client_msg_cb(int fd, int what, void *v) break; case SSL_ERROR_WANT_READ: /* ssl wants to read, so schedule the read handler */ - sudo_ev_add(closure->read_ev->base, closure->read_ev, NULL, false); + if (sudo_ev_add(closure->read_ev->base, closure->read_ev, NULL, false) == -1) + sudo_warnx(U_("unable to add event to queue")); debug_return; case SSL_ERROR_WANT_WRITE: /* re-schedule the write handler */ - sudo_ev_add(closure->write_ev->base, closure->write_ev, NULL, false); + if (sudo_ev_add(closure->write_ev->base, closure->write_ev, NULL, false) == -1) + sudo_warnx(U_("unable to add event to queue")); debug_return; default: break;