isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash in visudo introduced in sudo 1.8.9 when an IP address or

Browse Source 
network is used in a host-based Defaults entry.  Bug #766
This commit is contained in:
Todd C. Miller
2017-01-07 19:50:05 -07:00
parent 0c3a8085b3
commit 90e1f4ec3e
5 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
MANIFEST
View File

@@ -472,6 +472,8 @@ plugins/sudoers/regress/visudo/test7.sh
plugins/sudoers/regress/visudo/test8.err.ok plugins/sudoers/regress/visudo/test8.err.ok
plugins/sudoers/regress/visudo/test8.out.ok plugins/sudoers/regress/visudo/test8.out.ok
plugins/sudoers/regress/visudo/test8.sh plugins/sudoers/regress/visudo/test8.sh
plugins/sudoers/regress/visudo/test9.out.ok
plugins/sudoers/regress/visudo/test9.sh
plugins/sudoers/set_perms.c plugins/sudoers/set_perms.c
plugins/sudoers/solaris_audit.c plugins/sudoers/solaris_audit.c
plugins/sudoers/solaris_audit.h plugins/sudoers/solaris_audit.h

2
plugins/sudoers/interfaces.c
View File

@@ -43,7 +43,7 @@
# define INADDR_NONE ((unsigned int)-1) # define INADDR_NONE ((unsigned int)-1)
#endif #endif
static struct interface_list interfaces; static struct interface_list interfaces = SLIST_HEAD_INITIALIZER(interfaces);
/* /*
* Parse a space-delimited list of IP address/netmask pairs and * Parse a space-delimited list of IP address/netmask pairs and

1
plugins/sudoers/regress/visudo/test9.out.ok Normal file
View File

@@ -0,0 +1 @@
stdin: parsed OK

12
plugins/sudoers/regress/visudo/test9.sh Executable file
View File

@@ -0,0 +1,12 @@
#!/bin/sh
#
# Test IP and network address in host-based Defaults statements
# Bugzilla #766
#
./visudo -cf - <<-EOF
Defaults@127.0.0.1 !authenticate
Defaults@10.0.0.0/8 !always_set_home
EOF
exit 0

7
plugins/sudoers/visudo.c
View File

@@ -61,6 +61,7 @@
#endif #endif
#include "sudoers.h" #include "sudoers.h"
#include "interfaces.h"
#include "parse.h" #include "parse.h"
#include "redblack.h" #include "redblack.h"
#include "sudoers_version.h" #include "sudoers_version.h"
@@ -815,9 +816,11 @@ group_plugin_query(const char *user, const char *group, const struct passwd *pw)
} }
/* STUB */ /* STUB */
struct interface *get_interfaces(void) struct interface_list *
get_interfaces(void)
{ {
return NULL; static struct interface_list dummy = SLIST_HEAD_INITIALIZER(interfaces);
return &dummy;
} }
/* /*