isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary NULL checks in the RUNAS_CHANGED macro. The

Browse Source 
only place where the pointers could be NULL is in visudo_json.c but
we already check for "next" being NULL there.  Quiets a cppcheck
warning.
This commit is contained in:
Todd C. Miller
2016-05-10 06:32:55 -06:00
parent 398ddd0467
commit 8b4de84049
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/sudoers/parse.h
View File

@@ -71,8 +71,7 @@
* Returns true if the runas user and group lists match, else false. * Returns true if the runas user and group lists match, else false.
*/ */
#define RUNAS_CHANGED(cs1, cs2) \ #define RUNAS_CHANGED(cs1, cs2) \
((cs1) == NULL || (cs2) == NULL || \ ((cs1)->runasuserlist != (cs2)->runasuserlist || \
(cs1)->runasuserlist != (cs2)->runasuserlist || \
(cs1)->runasgrouplist != (cs2)->runasgrouplist) (cs1)->runasgrouplist != (cs2)->runasgrouplist)
#define SUDO_DIGEST_SHA224 0 #define SUDO_DIGEST_SHA224 0