isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CodeQL "Multiplication result converted to larger type" warnings.

Browse Source
This commit is contained in:
Todd C. Miller
2021-12-10 13:33:07 -07:00
parent 014339948c
commit 83defd3a6f
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/sudoers/defaults.c
View File

@@ -930,7 +930,7 @@ store_timespec(const char *str, union sudo_defs_val *sd_un)
{ {
struct timespec ts; struct timespec ts;
char sign = '+'; char sign = '+';
int i; long i;
debug_decl(store_timespec, SUDOERS_DEBUG_DEFAULTS); debug_decl(store_timespec, SUDOERS_DEBUG_DEFAULTS);
sudo_timespecclear(&ts); sudo_timespecclear(&ts);

6
plugins/sudoers/pwutil_impl.c
View File

@@ -359,12 +359,12 @@ struct cache_item *
sudo_make_grlist_item(const struct passwd *pw, char * const *unused1) sudo_make_grlist_item(const struct passwd *pw, char * const *unused1)
{ {
char *cp; char *cp;
size_t nsize, ngroups, total, len; size_t groupname_len, len, ngroups, nsize, total;
struct cache_item_grlist *grlitem; struct cache_item_grlist *grlitem;
struct group_list *grlist; struct group_list *grlist;
struct gid_list *gidlist; struct gid_list *gidlist;
struct group *grp = NULL; struct group *grp = NULL;
int i, groupname_len; int i;
debug_decl(sudo_make_grlist_item, SUDOERS_DEBUG_NSS); debug_decl(sudo_make_grlist_item, SUDOERS_DEBUG_NSS);
gidlist = sudo_get_gidlist(pw, ENTRY_TYPE_ANY); gidlist = sudo_get_gidlist(pw, ENTRY_TYPE_ANY);
@@ -376,7 +376,7 @@ sudo_make_grlist_item(const struct passwd *pw, char * const *unused1)
} }
#ifdef _SC_LOGIN_NAME_MAX #ifdef _SC_LOGIN_NAME_MAX
groupname_len = MAX((int)sysconf(_SC_LOGIN_NAME_MAX), 32); groupname_len = MAX(sysconf(_SC_LOGIN_NAME_MAX), 32);
#else #else
groupname_len = MAX(LOGIN_NAME_MAX, 32); groupname_len = MAX(LOGIN_NAME_MAX, 32);
#endif #endif