isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix use of uninitialized variable (conf) if sudoers_debug_register()

Browse Source 
happens to fail.
This commit is contained in:
Todd C. Miller
2018-03-01 10:18:48 -07:00
parent 73b5f961ee
commit 8275ab873f
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/sudoers/cvtsudoers.c
View File

@@ -82,7 +82,7 @@ main(int argc, char *argv[])
int ch, exitcode = EXIT_FAILURE; int ch, exitcode = EXIT_FAILURE;
enum sudoers_formats output_format = format_ldif; enum sudoers_formats output_format = format_ldif;
enum sudoers_formats input_format = format_sudoers; enum sudoers_formats input_format = format_sudoers;
struct cvtsudoers_config *conf; struct cvtsudoers_config *conf = NULL;
const char *input_file = "-"; const char *input_file = "-";
const char *output_file = "-"; const char *output_file = "-";
const char *conf_file = _PATH_CVTSUDOERS_CONF; const char *conf_file = _PATH_CVTSUDOERS_CONF;
@@ -398,12 +398,14 @@ cvtsudoers_conf_free(struct cvtsudoers_config *conf)
{ {
debug_decl(cvtsudoers_conf_free, SUDOERS_DEBUG_UTIL) debug_decl(cvtsudoers_conf_free, SUDOERS_DEBUG_UTIL)
free(conf->sudoers_base); if (conf != NULL) {
free(conf->input_format); free(conf->sudoers_base);
free(conf->output_format); free(conf->input_format);
conf->sudoers_base = NULL; free(conf->output_format);
conf->input_format = NULL; conf->sudoers_base = NULL;
conf->output_format = NULL; conf->input_format = NULL;
conf->output_format = NULL;
}
debug_return; debug_return;
} }