isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove extraneous while() from botched do {} while() loop

Browse Source 
conversion to use sudo_strsplit.  Noticed by Radovan Sroka.
This commit is contained in:
Todd C. Miller
2015-08-18 08:34:10 -06:00
parent 2b6085760c
commit 7ef9b5827e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/sudoers/sudoers.c
View File

@@ -1214,7 +1214,7 @@ find_editor(int nfiles, char **files, int *argc_out, char ***argv_out)
files, argc_out, argv_out, NULL); files, argc_out, argv_out, NULL);
if (editor_path == NULL && errno != ENOENT) if (editor_path == NULL && errno != ENOENT)
debug_return_str(NULL); debug_return_str(NULL);
} while (ep != NULL && editor_path == NULL); }
} }
if (!editor_path) { if (!editor_path) {
audit_failure(NewArgc, NewArgv, N_("%s: command not found"), audit_failure(NewArgc, NewArgv, N_("%s: command not found"),

2
plugins/sudoers/visudo.c
View File

@@ -332,7 +332,7 @@ get_editor(int *editor_argc, char ***editor_argv)
editor_argc, editor_argv, whitelist); editor_argc, editor_argv, whitelist);
if (editor_path == NULL && errno != ENOENT) if (editor_path == NULL && errno != ENOENT)
debug_return_str(NULL); debug_return_str(NULL);
} while (ep != NULL && editor_path == NULL); }
} }
if (editor_path == NULL) if (editor_path == NULL)
sudo_fatalx(U_("no editor found (editor path = %s)"), def_editor); sudo_fatalx(U_("no editor found (editor path = %s)"), def_editor);