isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use -Wl,--no-undefined with the sanitizers/fuzzers.

Browse Source 
It breaks linking when using -fsanitize with clang at least.
This commit is contained in:
Todd C. Miller
2023-01-19 19:40:35 -07:00
parent c6cc680069
commit 7a64275a3d
2 changed files with 36 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
configure vendored
View File

@@ -19824,9 +19824,11 @@ fi
# #
# Don't allow undefined symbols, even in shared libraries, if possible. # Don't allow undefined symbols, even in shared libraries, if possible.
# This will detect missing symbols at build-time instead of run-time. # This will detect missing symbols at build-time instead of run-time
# but is incompatible with the sanitizers/fuzzers.
# We must set this *before* the library tests. # We must set this *before* the library tests.
# #
if test X"${enable_sanitizer}{enable_fuzzer}" = X"nono"; then
case "$host_os" in case "$host_os" in
freebsd*|dragonfly*|openbsd*) freebsd*|dragonfly*|openbsd*)
# On FreeBSD and Dragonfly, environ is filled in by the # On FreeBSD and Dragonfly, environ is filled in by the
@@ -19915,6 +19917,7 @@ fi
;; ;;
esac esac
fi
# #
# HP-UX may need to define _XOPEN_SOURCE_EXTENDED to expose MSG_WAITALL. # HP-UX may need to define _XOPEN_SOURCE_EXTENDED to expose MSG_WAITALL.

5
configure.ac
View File

@@ -2451,9 +2451,11 @@ AC_SYS_YEAR2038
# #
# Don't allow undefined symbols, even in shared libraries, if possible. # Don't allow undefined symbols, even in shared libraries, if possible.
# This will detect missing symbols at build-time instead of run-time. # This will detect missing symbols at build-time instead of run-time
# but is incompatible with the sanitizers/fuzzers.
# We must set this *before* the library tests. # We must set this *before* the library tests.
# #
if test X"${enable_sanitizer}{enable_fuzzer}" = X"nono"; then
case "$host_os" in case "$host_os" in
freebsd*|dragonfly*|openbsd*) freebsd*|dragonfly*|openbsd*)
# On FreeBSD and Dragonfly, environ is filled in by the # On FreeBSD and Dragonfly, environ is filled in by the
@@ -2468,6 +2470,7 @@ case "$host_os" in
AX_CHECK_LINK_FLAG([-Wl,--no-undefined], [AX_APPEND_FLAG([-Wl,--no-undefined], [LDFLAGS])]) AX_CHECK_LINK_FLAG([-Wl,--no-undefined], [AX_APPEND_FLAG([-Wl,--no-undefined], [LDFLAGS])])
;; ;;
esac esac
fi
# #
# HP-UX may need to define _XOPEN_SOURCE_EXTENDED to expose MSG_WAITALL. # HP-UX may need to define _XOPEN_SOURCE_EXTENDED to expose MSG_WAITALL.