isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intercept_check_policy: fix potential NUL dereference on the error path.

Browse Source
This commit is contained in:
Todd C. Miller
2021-08-26 17:29:30 -06:00
parent ba171724f7
commit 75bac8dee9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/exec_intercept.c
View File

@@ -226,7 +226,8 @@ update_command_info(char * const *old_command_info, const char *cmnd,
for (n = 0; old_command_info[n] != NULL; n++) { for (n = 0; old_command_info[n] != NULL; n++) {
const char *cp = old_command_info[n]; const char *cp = old_command_info[n];
if (strncmp(cp, "command=", sizeof("command=") - 1) == 0) { if (strncmp(cp, "command=", sizeof("command=") - 1) == 0) {
free(tmp_command); if (tmp_command != NULL)
continue;
tmp_command = sudo_new_key_val("command", cmnd); tmp_command = sudo_new_key_val("command", cmnd);
if (tmp_command == NULL) { if (tmp_command == NULL) {
goto bad; goto bad;
@@ -411,7 +412,7 @@ done:
if (closure->errstr == NULL) if (closure->errstr == NULL)
closure->errstr = N_("policy plugin error"); closure->errstr = N_("policy plugin error");
audit_error(policy_plugin.name, SUDO_POLICY_PLUGIN, closure->errstr, audit_error(policy_plugin.name, SUDO_POLICY_PLUGIN, closure->errstr,
command_info); command_info ? command_info : closure->details->info);
closure->state = POLICY_ERROR; closure->state = POLICY_ERROR;
} }
if (!ISSET(closure->details->flags, CD_INTERCEPT)) { if (!ISSET(closure->details->flags, CD_INTERCEPT)) {